fix null pointer dereference in php_mail_detect_multiple_crlf via error_log#20862
fix null pointer dereference in php_mail_detect_multiple_crlf via error_log#20862jordikroon wants to merge 2 commits intophp:masterfrom
Conversation
jordikroon
force-pushed
the
fix/gh20858
branch
from
dc75e05 to
93f25d8
Compare
|
nice but be mindful next times when a ticket had been assigned already. |
|
Sorry for that @devnexen. I should have put a comment before working on it. I can't self assign myself unfortunately. |
|
it s fine no big deal. Cheers. |
jordikroon
force-pushed
the
fix/gh20858
branch
3 times, most recently
from
08b1619 to
11f4730
Compare
jordikroon
force-pushed
the
fix/gh20858
branch
from
11f4730 to
51cc3dd
Compare
devnexen
left a comment
devnexen
left a comment
There was a problem hiding this comment.
the fix itself looks good, but I ll let it live for a while, e.g. tests might need updates/changes.
|
Thank you all for your feedback. And for going through my learning experience 😅 Much appreciated. |
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
I was planning on refactoring that code a bit more, mainly adding a warning that the to param is required for the email mode. But that is a reasonable fix for the time being.
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
LGTM. Thanks @jordikroon! @devnexen Feel free to merge when you're happy with the PR.
| unlink($filePath); | ||
| } | ||
| ?> | ||
| --EXPECTF-- |
|
Thanks ! |
4 participants
Fixes #20858